[ExecuTorch][WebGPU] Add select/boolean ops (where, scalar compares, logical_not) to the WebGPU backend by JCNTH · Pull Request #20925 · pytorch/executorch

JCNTH · 2026-07-14T21:48:42Z

Stack from ghstack (oldest at bottom):

Add aten.where.self, scalar comparisons (aten.{eq,ne,le,ge,lt,gt}.Scalar), and aten.logical_not.default handlers for the training tail. The scalar compares and logical_not are generated from ONE templated byte-packed-bool shader (runtime/ops/boolean_op/) rather than per-op hand-written kernels — mirroring the binary_op codegen and Vulkan's grouping of comparison ops as ${OPERATOR} variants (backends/vulkan/runtime/graph/ops/glsl/binary_op_buffer.yaml).

Key changes:

runtime/ops/boolean_op/ — one boolean_op.wgsl template + boolean_op.yaml (variants compare_{eq,ne,le,ge,lt,gt} + logical_not) expand to the per-variant *_wgsl.h; BooleanOp.cpp holds one shared dispatch_bool_op helper (pack 4 bools per u32 word, one thread per word) plus the seven WEBGPU_REGISTER_OPs.
runtime/ops/where/ — ternary select, kept as its own kernel/handler (non-bool-family, as in Vulkan).
op_registry.py — register the net-new aten.{ne,lt,le,ge,gt}.Scalar + aten.logical_not.default OpFeatures (eq.Scalar already on master).
CMakeLists.txt WEBGPU_SRCS — wire boolean_op/BooleanOp.cpp.

aten.where.self already had Vulkan OpFeatures; the scalar-compare + logical_not registrations are additive to the shared Vulkan registry.

Co-authored-with: Claude Code.
@exported-using-ghexport

Differential Revision: D111755122

[ghstack-poisoned]

pytorch-bot · 2026-07-14T21:48:46Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20925

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure, 6 Unclassified Failures

As of commit 9127593 with merge base 21554e5 ():

NEW FAILURE - The following job has failed:

pull / test-multimodal-linux (gemma3-4b) / linux-job (gh)
RuntimeError: Command docker exec -t 5bc9b633df2e15a3dd64f343b2d80753333b844be7617b3fef6d3070c0e90b24 /exec failed with exit code 139

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

periodic / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory
periodic / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory
periodic / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory
periodic / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory
periodic / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory
periodic / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
An error occurred trying to start process '/usr/bin/bash' with working directory '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch'. No such file or directory

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-arm-backend-no-driver (test_pytest_models_tosa) / linux-job (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2026-07-14T21:49:24Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

SS-JIA

Review automatically exported from Phabricator review in Meta.

[ghstack-poisoned]

SS-JIA

Review automatically exported from Phabricator review in Meta.

[ghstack-poisoned]

…logical_not) to the WebGPU backend Pull Request resolved: #20925 Add `aten.where.self`, scalar comparisons (`aten.{eq,ne,le,ge,lt,gt}.Scalar`), and `aten.logical_not.default` handlers for the training tail. The scalar compares and `logical_not` are generated from ONE templated byte-packed-bool shader (`runtime/ops/boolean_op/`) rather than per-op hand-written kernels — mirroring the `binary_op` codegen and Vulkan's grouping of comparison ops as `${OPERATOR}` variants (`backends/vulkan/runtime/graph/ops/glsl/binary_op_buffer.yaml`). Key changes: - `runtime/ops/boolean_op/` — one `boolean_op.wgsl` template + `boolean_op.yaml` (variants `compare_{eq,ne,le,ge,lt,gt}` + `logical_not`) expand to the per-variant `*_wgsl.h`; `BooleanOp.cpp` holds one shared `dispatch_bool_op` helper (pack 4 bools per `u32` word, one thread per word) plus the seven `WEBGPU_REGISTER_OP`s. - `runtime/ops/where/` — ternary select, kept as its own kernel/handler (non-bool-family, as in Vulkan). - `op_registry.py` — register the net-new `aten.{ne,lt,le,ge,gt}.Scalar` + `aten.logical_not.default` `OpFeatures` (`eq.Scalar` already on master). - `CMakeLists.txt` `WEBGPU_SRCS` — wire `boolean_op/BooleanOp.cpp`. `aten.where.self` already had Vulkan `OpFeatures`; the scalar-compare + `logical_not` registrations are additive to the shared Vulkan registry. Co-authored-with: Claude Code. ghstack-source-id: 405026062 @exported-using-ghexport Differential Revision: [D111755122](https://our.internmc.facebook.com/intern/diff/D111755122/)

Update

db3782f

[ghstack-poisoned]

JCNTH requested review from SS-JIA, kirklandsign and larryliu0820 as code owners July 14, 2026 21:48

JCNTH temporarily deployed to cadence July 14, 2026 21:48 — with GitHub Actions Inactive

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 14, 2026

JCNTH temporarily deployed to cadence July 14, 2026 23:30 — with GitHub Actions Inactive

JCNTH temporarily deployed to cadence July 15, 2026 00:01 — with GitHub Actions Inactive

SS-JIA requested changes Jul 16, 2026

View reviewed changes

Update

c064502

[ghstack-poisoned]

JCNTH temporarily deployed to cadence July 16, 2026 23:48 — with GitHub Actions Inactive

JCNTH temporarily deployed to cadence July 17, 2026 01:52 — with GitHub Actions Inactive

Update

7327dcc

[ghstack-poisoned]

JCNTH temporarily deployed to cadence July 17, 2026 04:39 — with GitHub Actions Inactive

JCNTH mentioned this pull request Jul 17, 2026

[ExecuTorch][WebGPU] Glob runtime/ops sources in CMakeLists #21005

Merged

JCNTH temporarily deployed to cadence July 17, 2026 05:08 — with GitHub Actions Inactive

SS-JIA approved these changes Jul 17, 2026

View reviewed changes

Update

9127593

[ghstack-poisoned]

JCNTH temporarily deployed to cadence July 21, 2026 05:02 — with GitHub Actions Inactive

JCNTH temporarily deployed to cadence July 21, 2026 05:30 — with GitHub Actions Inactive

meta-codesync Bot merged commit 7ba6cf7 into gh/JCNTH/64/base Jul 21, 2026
178 of 189 checks passed

meta-codesync Bot deleted the gh/JCNTH/64/head branch July 21, 2026 16:22

meta-codesync Bot temporarily deployed to cherry-pick-bot July 21, 2026 16:22 Inactive

pytorchbot mentioned this pull request Jul 21, 2026

[ExecuTorch][WebGPU] Add select/boolean ops (where, scalar compares, logical_not) to the WebGPU backend #21078

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ExecuTorch][WebGPU] Add select/boolean ops (where, scalar compares, logical_not) to the WebGPU backend#20925

[ExecuTorch][WebGPU] Add select/boolean ops (where, scalar compares, logical_not) to the WebGPU backend#20925
meta-codesync[bot] merged 6 commits into
gh/JCNTH/64/basefrom
gh/JCNTH/64/head

JCNTH commented Jul 14, 2026 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

SS-JIA left a comment

Uh oh!

SS-JIA left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JCNTH commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20925

❌ 1 New Failure, 1 Unrelated Failure, 6 Unclassified Failures

Uh oh!

github-actions Bot commented Jul 14, 2026

This PR needs a release notes: label

Uh oh!

SS-JIA left a comment

Choose a reason for hiding this comment

Uh oh!

SS-JIA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JCNTH commented Jul 14, 2026 •

edited

Loading

pytorch-bot Bot commented Jul 14, 2026 •

edited

Loading

This PR needs a `release notes:` label